Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OTP-26 to CI #284

Merged
merged 3 commits into from
May 17, 2023
Merged

Add OTP-26 to CI #284

merged 3 commits into from
May 17, 2023

Conversation

seriyps
Copy link
Member

@seriyps seriyps commented May 16, 2023 •
edited

@seriyps seriyps force-pushed the otp-26 branch 2 times, most recently from 4087b14 to 4801c00 Compare May 16, 2023 14:02
@seriyps
Copy link
Member Author

seriyps commented May 17, 2023

Ok, it seems there are at least two incompatibilities with OTP-26.
CT logs from the build: https://github.com/epgsql/epgsql/suites/12932403903/artifacts/700838734

  1. Unverified server certificates are causing error by default now: {ssl_negotiation_failed, {options,incompatible, [{verify,verify_peer},{cacerts,undefined}]}}. I think it can be fixed by setting {verify, verify_none} option
  2. inet port's private protocol we were abusing have changed OTP26 erlang:port_command breaking change? erlang/otp#7130 (comment)

@seriyps
Make it compatible with OTP-26
71a6b90 
* Don't call `prim_inet` port directly
* Add `verify=verify_none` option in SSL tests
@seriyps
Drop OTP-20
6d04312 
So OTP_RELEASE macro could be freely used
@seriyps seriyps marked this pull request as ready for review May 17, 2023 14:38
@seriyps seriyps requested a review from davidw May 17, 2023 14:38
@seriyps seriyps merged commit 57ed412 into epgsql:devel May 17, 2023
6 checks passed
@seriyps seriyps mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidw davidw davidw approved these changes

@onno-vos-dev onno-vos-dev onno-vos-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seriyps @davidw @onno-vos-dev