Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select2 bootstrap 5 theme fix #1044

Merged
merged 2 commits into from Aug 31, 2023
Merged

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Aug 30, 2023

This integrates a different theme pack into our saas compilation so the custom colors are right.
I'm also increasing the default cache timeout so Heavy Select2s don't stop working after 5 minutes.

closes #860 馃帀

@felixrindt felixrindt added the [C] design/ui Enhancement of existing views label Aug 30, 2023
@felixrindt felixrindt requested a review from jeriox August 30, 2023 18:30
@felixrindt
Copy link
Member Author

felixrindt commented Aug 30, 2023

Looks great now, apart from the bottom border being cut off...

image


image

@felixrindt felixrindt force-pushed the select2-bootstrap-5-theme-fix branch from 75052ea to 7bcc492 Compare August 30, 2023 18:57
@coveralls
Copy link

Coverage Status

coverage: 89.142%. remained the same when pulling 7bcc492 on select2-bootstrap-5-theme-fix into f062de7 on main.

@felixrindt felixrindt merged commit ab11802 into main Aug 31, 2023
18 checks passed
@felixrindt felixrindt deleted the select2-bootstrap-5-theme-fix branch August 31, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] design/ui Enhancement of existing views
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select2 bootstrap5 theme not working
3 participants