Password reset button for managers #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeriox
requested changes
Feb 28, 2021
ephios/core/templates/core/userprofile_confirm_password_reset.html
Outdated
Show resolved
Hide resolved
ephios/core/templates/core/userprofile_confirm_password_reset.html
Outdated
Show resolved
Hide resolved
| @@ -19,6 +19,13 @@ <h1>{% trans "Edit user" %}</h1> | |||
| <h1>{% trans "Add new user" %}</h1> | |||
| {% endif %} | |||
| </div> | |||
| {% if userprofile %} | |||
| <div class="float-right d-flex"> | |||
There was a problem hiding this comment.
I don't like that the button is so close to the field below and it appears kinda lost up there. Maybe put it next to delete button which triggers a "similar" action? Also I'd prefer to have another color for the button as this now indicates the same destructivity as deleting the user.
There was a problem hiding this comment.
I feel like this looks also weird... more ideas? I guess it would be okay though
…n-for-managers' into enhancement/password-reset-button-for-managers
jeriox
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #287