Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add display of pending consequences for the current user #337

Merged
merged 14 commits into from May 4, 2021
Merged

Add display of pending consequences for the current user #337

merged 14 commits into from May 4, 2021

Conversation

strawberriesandcheese
Copy link
Contributor

@strawberriesandcheese strawberriesandcheese commented Feb 28, 2021 •
edited by jeriox

Closes #239 closes #262

@strawberriesandcheese strawberriesandcheese self-assigned this Feb 28, 2021
@coveralls
Copy link

coveralls commented Feb 28, 2021 •
edited

Coverage Status

Coverage increased (+0.09%) to 88.834% when pulling 8463220 on feature/pending-consequences into 09e1486 on main.

@strawberriesandcheese strawberriesandcheese changed the title Add display of pending changes for the current user Add display of pending consequences for the current user Feb 28, 2021
@strawberriesandcheese strawberriesandcheese linked an issue Feb 28, 2021 that may be closed by this pull request
Improve decimal formatting for consequences/workhours #262
Closed
jeriox
jeriox reviewed Feb 28, 2021
View reviewed changes
ephios/core/consequences.py Outdated Show resolved Hide resolved
@jeriox jeriox marked this pull request as ready for review May 4, 2021 21:03
@jeriox jeriox requested a review from felixrindt May 4, 2021 21:03
felixrindt
felixrindt reviewed May 4, 2021
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can increase coverage?!

ephios/core/templatetags/user_extras.py Outdated Show resolved Hide resolved
@jeriox jeriox requested a review from felixrindt May 4, 2021 21:31
@jeriox jeriox enabled auto-merge (squash) May 4, 2021 22:00
@jeriox jeriox merged commit 576a9c5 into main May 4, 2021
@jeriox jeriox deleted the feature/pending-consequences branch May 4, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox left review comments

@felixrindt felixrindt felixrindt approved these changes

Assignees

@strawberriesandcheese strawberriesandcheese

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve decimal formatting for consequences/workhours Pending consequences
4 participants
@strawberriesandcheese @coveralls @felixrindt @jeriox