Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add conflicting_shifts signup checker #361

Merged
merged 7 commits into from Mar 11, 2021
Merged

add conflicting_shifts signup checker #361

merged 7 commits into from Mar 11, 2021

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Mar 9, 2021

closes #233

@jeriox jeriox requested a review from felixrindt March 9, 2021 17:29
@coveralls
Copy link

coveralls commented Mar 10, 2021 •
edited

Coverage Status

Coverage decreased (-0.008%) to 88.308% when pulling eac4ab1 on feature/overlapping_shift into 40ebb0b on main.

felixrindt
felixrindt requested changes Mar 10, 2021
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple but such a nice feature!

ephios/plugins/basesignup/templates/basesignup/section_based/fragment_participant.html Show resolved Hide resolved
ephios/core/templates/core/disposition/fragment_participation.html Show resolved Hide resolved
@jeriox jeriox requested a review from felixrindt March 11, 2021 00:45
@jeriox jeriox merged commit 7d04d32 into main Mar 11, 2021
@jeriox jeriox deleted the feature/overlapping_shift branch March 11, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrindt felixrindt felixrindt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "conflicting shifts" signup checker to BaseSignupMethod
3 participants
@jeriox @coveralls @felixrindt