fix custom notification for deleted event #451
Conversation
| data=dict(email=participant.email, event_id=event.id, content=content), | ||
| data=dict( | ||
| email=participant.email, | ||
| event_id=event.id, |
There was a problem hiding this comment.
not at the moment, but I think we should keep the ability to fetch the event from the db for sending to query for more information (if it exists)
| email=participant.email, | ||
| event_id=event.id, | ||
| content=content, | ||
| event_title=event.title, |
There was a problem hiding this comment.
I must admit this feels like fixing symptoms. There are more occasions in which we will try to fetch objects in Notification sending that have been deleted in the meantime...
There was a problem hiding this comment.
well usually you won't confirm people directly before deleting the event, so this will be the case where it happens IMO.
What would be your suggestion?
There was a problem hiding this comment.
I think the best solution would be to send Notifications without delay, but that's for another day.
| email=participant.email, | ||
| event_id=event.id, | ||
| content=content, | ||
| event_title=event.title, |
There was a problem hiding this comment.
I think the best solution would be to send Notifications without delay, but that's for another day.
No description provided.