Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor SignupStats to use missing and free counts #511

Merged
merged 10 commits into from Jul 17, 2021
Merged

refactor SignupStats to use missing and free counts #511

merged 10 commits into from Jul 17, 2021

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Jul 17, 2021 •
edited

closes #457

@coveralls
Copy link

coveralls commented Jul 17, 2021 •
edited

Coverage Status

Coverage increased (+0.02%) to 89.264% when pulling 65fa897 on feature/missing-participant-count into 5adfac9 on main.

felixrindt
felixrindt requested changes Jul 17, 2021
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a test for section-signup-stats

ephios/core/signup/methods.py Outdated Show resolved Hide resolved
ephios/plugins/basesignup/signup/section_based.py Outdated Show resolved Hide resolved
ephios/plugins/basesignup/signup/section_based.py Outdated Show resolved Hide resolved
ephios/plugins/basesignup/signup/section_based.py Outdated Show resolved Hide resolved
@jeriox jeriox requested a review from felixrindt July 17, 2021 16:12
@felixrindt felixrindt force-pushed the feature/missing-participant-count branch from 052a97d to fdc997b Compare July 17, 2021 16:42
felixrindt
felixrindt requested changes Jul 17, 2021
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the markup. I'm mildly happy with results on mobile. the type badge placing is a little weird.

ephios/plugins/basesignup/signup/section_based.py Outdated Show resolved Hide resolved
ephios/plugins/basesignup/signup/section_based.py Show resolved Hide resolved
@jeriox @felixrindt
Update ephios/plugins/basesignup/signup/section_based.py
53fe952 
Co-authored-by: Felix Rindt <felix@rindt.me>
@felixrindt felixrindt mentioned this pull request Jul 17, 2021
Merged
3 tasks
@jeriox jeriox requested a review from felixrindt July 17, 2021 19:44
@jeriox jeriox requested a review from felixrindt July 17, 2021 20:28
felixrindt
felixrindt approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve all comments

ephios/plugins/basesignup/signup/section_based.py Outdated Show resolved Hide resolved
@jeriox jeriox enabled auto-merge (squash) July 17, 2021 20:34
@jeriox jeriox merged commit 29a54b1 into main Jul 17, 2021
@jeriox jeriox deleted the feature/missing-participant-count branch July 17, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrindt felixrindt felixrindt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor SignupStats
3 participants
@jeriox @coveralls @felixrindt