add django-renderpdf #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
discussion result: this is not what we want. If users want that kind of pdf, they can use the print feature of their browser. We go for reportlab and build a few well-thought PDFs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe closes #10
@felixrindt as you stated that building PDFs with reportlab i looked into alternatives. This branch uses https://github.com/WhyNotHugo/django-renderpdf to generate PDFs via HTML rendered from the already used templates.
https://github.com/fdemmer/django-weasyprint follows a similar approach and looks a bit more flexible. Downside of both packages is that the underlying library weasyprint requires GTK+ libraries that cannot be installed with pip/poetry (see https://weasyprint.readthedocs.io/en/stable/install.html for details). What do you think?