Deal with missing/broken signup methods #667

felixrindt · 2022-01-05T18:05:49Z

Fixes #557

catch errors of found signup methods
deal with missing signup methods
tests
get rid of this report_exception function and use proper logging instead - using the admin-mailer logging backend
migrate Make notification sending more robust #655 to use the new logging

coveralls · 2022-01-05T18:11:16Z

Coverage decreased (-0.05%) to 86.851% when pulling af0275f on fix/missing_signup_method_handling into 0de7fc9 on main.

ephios/core/templates/core/fragments/signup_method_missing.html

ephios/settings.py

ephios/core/models/events.py

jeriox reviewed Jan 5, 2022

View reviewed changes

ephios/core/templates/core/fragments/signup_method_missing.html Outdated Show resolved Hide resolved

ephios/settings.py Show resolved Hide resolved

felixrindt commented Jan 6, 2022

View reviewed changes

ephios/core/models/events.py Show resolved Hide resolved

felixrindt and others added 6 commits February 22, 2022 17:10

catch errors from signup methods

1035858

update logging config

3225765

add test fixture to check log for exceptions

25220a5

deal with missing signup method

63dcc4a

add test

8f9d646

fix missing participation

7961eaa

felixrindt force-pushed the fix/missing_signup_method_handling branch from 69917d2 to bbaff47 Compare February 22, 2022 18:03

felixrindt requested a review from jeriox February 22, 2022 18:03

remove exception info from template

af0275f

felixrindt force-pushed the fix/missing_signup_method_handling branch from bbaff47 to af0275f Compare February 22, 2022 20:18

jeriox approved these changes Feb 26, 2022

View reviewed changes

felixrindt enabled auto-merge (rebase) February 26, 2022 20:23

felixrindt merged commit bdb511b into main Feb 26, 2022

felixrindt deleted the fix/missing_signup_method_handling branch February 26, 2022 20:23

Provide feedback