Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add oauth2 flow as provider #904

Merged
merged 23 commits into from May 18, 2023
Merged

add oauth2 flow as provider #904

merged 23 commits into from May 18, 2023

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Mar 6, 2023 •
edited

@jeriox jeriox marked this pull request as ready for review March 8, 2023 21:20
@jeriox jeriox requested a review from felixrindt March 8, 2023 21:20
@jeriox jeriox mentioned this pull request Mar 8, 2023
Closed
felixrindt
felixrindt requested changes Mar 9, 2023
View reviewed changes
ephios/extra/permissions.py Show resolved Hide resolved
ephios/core/views/settings.py Outdated Show resolved Hide resolved
ephios/api/signals.py Show resolved Hide resolved
ephios/settings.py Show resolved Hide resolved
ephios/settings.py Outdated Show resolved Hide resolved
@jeriox jeriox requested a review from felixrindt March 12, 2023 13:17
felixrindt
felixrindt reviewed Mar 12, 2023
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess for this PR only thing left (besides addressing the small review comments) is making the pages look a little better...

@coveralls
Copy link

coveralls commented May 18, 2023 •
edited

Coverage Status

Coverage: 86.671% (-1.3%) from 87.921% when pulling 6aafcb7 on oauth2 into f57308c on main.

@jeriox jeriox mentioned this pull request May 18, 2023
Closed
@jeriox jeriox merged commit fa1b70e into main May 18, 2023
14 of 15 checks passed
@jeriox jeriox deleted the oauth2 branch May 18, 2023 12:17
@jeriox jeriox added the [C] feature New feature or request label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrindt felixrindt felixrindt approved these changes

Assignees
No one assigned
Labels
[C] feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeriox @coveralls @felixrindt