Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor logentry config save hook #988

Merged
merged 1 commit into from Jun 28, 2023
Merged

refactor logentry config save hook #988

merged 1 commit into from Jun 28, 2023

Conversation

felixrindt
Copy link
Member

Hmm #978 was insufficient for what I needed to do so I refactored it to this plain old method.

@felixrindt felixrindt added the [C] enhancement Changes to an existing feature making it better label Jun 28, 2023
@felixrindt felixrindt requested a review from jeriox June 28, 2023 15:25
@felixrindt felixrindt self-assigned this Jun 28, 2023
@coveralls
Copy link

coveralls commented Jun 28, 2023 •
edited

Coverage Status

coverage: 88.292% (-0.003%) from 88.295% when pulling a1fad28 on refactor-logentry-save-hook into c39d004 on main.

@felixrindt felixrindt enabled auto-merge (rebase) June 28, 2023 22:01
@felixrindt felixrindt merged commit 7e4bd35 into main Jun 28, 2023
18 checks passed
@felixrindt felixrindt deleted the refactor-logentry-save-hook branch June 28, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

Assignees

@felixrindt felixrindt

Labels
[C] enhancement Changes to an existing feature making it better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixrindt @coveralls @jeriox