feat: toggle swith to turn off and on #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this, I'm going to take over and add some minor changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a feature to turn it on and off as requested in this issue:
#2
Toggle:
Extension on:
Extension off:
P.S. Maybe is not the cleanest way to do it because I needed to change all the css selectors, my initial idea was to insert the css by JS, but it's hard to do it with manifest v3 and also create performance issues (the css will only be inserted after js is ready and run, so its possible to see the youtube default load 馃槥 ). So the best option that I think until now is to change html class