Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed collect backups filtering #1016

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Nov 1, 2023

closes #1012

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (bc486ac) 92.39% compared to head (f171af5) 92.37%.

❗ Current head f171af5 differs from pull request most recent head cee8c46. Consider uploading reports for the commit cee8c46 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
- Coverage   92.39%   92.37%   -0.02%     
==========================================
  Files          63       63              
  Lines       12066    12066              
==========================================
- Hits        11148    11146       -2     
- Misses        918      920       +2     
Files Coverage Δ
src/nlp/document.rs 94.55% <100.00%> (ø)
src/nlp/term.rs 100.00% <100.00%> (ø)
src/event_handlers/outputs.rs 94.98% <70.00%> (-0.68%) ⬇️
src/scanner/ferox_scanner.rs 77.77% <80.00%> (-0.24%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epi052 epi052 merged commit 6c0fe90 into main Nov 3, 2023
12 checks passed
@epi052 epi052 deleted the 1012-fix-collect-backups-filtering branch November 3, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Results generated from the --collect-backups flag do not get filtered
1 participant