Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom backup extension list #1035

Merged
merged 7 commits into from
Nov 25, 2023
Merged

custom backup extension list #1035

merged 7 commits into from
Nov 25, 2023

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Nov 25, 2023

closes #1029

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a714825) 92.31% compared to head (ab9a3b0) 92.33%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/config/container.rs 73.68% 5 Missing ⚠️
src/event_handlers/outputs.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
+ Coverage   92.31%   92.33%   +0.02%     
==========================================
  Files          63       63              
  Lines       12069    12103      +34     
==========================================
+ Hits        11141    11175      +34     
  Misses        928      928              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epi052 epi052 merged commit 38a1ed3 into main Nov 25, 2023
14 of 15 checks passed
@epi052 epi052 deleted the 1029-custom-backup-extension-list branch November 25, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] add new backup extensions
1 participant