Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added headers to regex filtering #1142

Merged
merged 8 commits into from
Jun 16, 2024
Merged

added headers to regex filtering #1142

merged 8 commits into from
Jun 16, 2024

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented May 12, 2024

Landing a Pull Request (PR)

closes #663
closes #1141
closes #1150
closes #1149
closes #1145

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@epi052 epi052 merged commit 57db4ad into main Jun 16, 2024
14 of 15 checks passed
@epi052 epi052 deleted the filter-headers-by-regex branch June 16, 2024 12:59
@epi052
Copy link
Owner Author

epi052 commented Jun 16, 2024

@all-contributors add @sitiom for infra and documentation

Copy link
Contributor

@epi052

I've put up a pull request to add @sitiom! 🎉

@epi052
Copy link
Owner Author

epi052 commented Jun 16, 2024

@all-contributors add @JulianGR for infra, documentation, and ideas

Copy link
Contributor

@epi052

I've put up a pull request to add @JulianGR! 🎉

@epi052
Copy link
Owner Author

epi052 commented Jun 16, 2024

@all-contributors add @wikamp-collaborator for ideas, infra

Copy link
Contributor

@epi052

I've put up a pull request to add @wikamp-collaborator! 🎉

@epi052
Copy link
Owner Author

epi052 commented Jun 16, 2024

@all-contributors add @L1-0 for bugs

Copy link
Contributor

@epi052

I've put up a pull request to add @L1-0! 🎉

@epi052
Copy link
Owner Author

epi052 commented Jun 16, 2024

@all-contributors add @sa7mon for ideas

Copy link
Contributor

@epi052

I've put up a pull request to add @sa7mon! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment