-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding feroxbuster as chocolatey package #807
Conversation
Hey, I think you need to update the license file for copyright year. It's still 2020. Maybe 2020-2023 is more suitable. If you don't mind, I can update the license in root folder and license in chocolatey too as one commit. |
yea, the range would be fine. ty! I read through the xml and it all looks good. are the checksums in the install package a manual process? i.e. do they need manually updated with each release? any thoughts on this? https://github.com/marketplace/actions/chocolatey-action (or a similar action?) |
I think the checksum is manual input. It can be automatic like editing the xml file with python everytime the release exist. It's good idea to use that github action for doing choco api key and choco push. I've not yet try, but it looks good. |
Note: Need to make the icon from logo and we can change the value in this xml
|
I never thanked you for putting this PR in... sorry! and thank you for taking the time on this one (as well as the menu/banner PR), i really do appreciate it! i saw that while reading through. been pushing this one off in favor of your other PR and one that I'm working, since it's not anything that will affect other branches. once i get those two in (probably today), i'll be able to work on this one |
|
Thank you for your appreciation, I'm so honored to contribute this project. I will push the commit for new logo soon. |
pushed 2.8.0 as part of testing this, all seemed to work. they say it goes through automated tasks and will eventually be available. I'll look into automating this some other time. for now, i'm ok with it just being a manual process |
thanks again for all your help! |
Note: The checksum value in xml need to be updated with the latest version |
Fixes #763
push the package to chocolatey using your API credential as explained in this page https://docs.chocolatey.org/en-us/create/create-packages-quick-start
Push the package to the Chocolatey community package repository:
So, every release of feroxbuster need to be pushed on chocolatey too. I think this can be automated using github workflow.
Landing a Pull Request (PR)
Long form explanations of most of the items below can be found in the CONTRIBUTING guide.
Branching checklist
Static analysis checks
cargo fmt
clippy
checks pass when runningcargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
Documentation
docs
, as needed. The docs live in a separate repository. Update the appropriate pages at the links below.Additional Tests