Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding feroxbuster as chocolatey package #807

Merged
merged 3 commits into from
Mar 11, 2023
Merged

Conversation

aancw
Copy link
Contributor

@aancw aancw commented Mar 6, 2023

Fixes #763

push the package to chocolatey using your API credential as explained in this page https://docs.chocolatey.org/en-us/create/create-packages-quick-start

Push the package to the Chocolatey community package repository:

choco apikey --api-key [API_KEY_HERE] -source https://push.chocolatey.org/
choco push package-name.1.1.0.nupkg --source https://push.chocolatey.org/ - nupkg file can be omitted if it is the only one in the directory.

So, every release of feroxbuster need to be pushed on chocolatey too. I think this can be automated using github workflow.

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@aancw
Copy link
Contributor Author

aancw commented Mar 6, 2023

Hey, I think you need to update the license file for copyright year. It's still 2020. Maybe 2020-2023 is more suitable. If you don't mind, I can update the license in root folder and license in chocolatey too as one commit.

@epi052
Copy link
Owner

epi052 commented Mar 6, 2023

yea, the range would be fine. ty!

I read through the xml and it all looks good.

are the checksums in the install package a manual process? i.e. do they need manually updated with each release?

any thoughts on this? https://github.com/marketplace/actions/chocolatey-action (or a similar action?)

@aancw
Copy link
Contributor Author

aancw commented Mar 7, 2023

I think the checksum is manual input. It can be automatic like editing the xml file with python everytime the release exist.

It's good idea to use that github action for doing choco api key and choco push. I've not yet try, but it looks good.

@aancw
Copy link
Contributor Author

aancw commented Mar 8, 2023

Note:

Need to make the icon from logo and we can change the value in this xml

    <!-- 
       //TODO: PLEASE CONVERT THE LOGO TO ICON
       <iconUrl>https://github.com/epi052/feroxbuster/raw/main/img/logo/default-cropped.png</iconUrl>
     -->

@epi052
Copy link
Owner

epi052 commented Mar 8, 2023

Note:

Need to make the icon from logo and we can change the value in this xml

    <!-- 
       //TODO: PLEASE CONVERT THE LOGO TO ICON
       <iconUrl>https://github.com/epi052/feroxbuster/raw/main/img/logo/default-cropped.png</iconUrl>
     -->

I never thanked you for putting this PR in... sorry! and thank you for taking the time on this one (as well as the menu/banner PR), i really do appreciate it!

i saw that while reading through. been pushing this one off in favor of your other PR and one that I'm working, since it's not anything that will affect other branches. once i get those two in (probably today), i'll be able to work on this one

@epi052
Copy link
Owner

epi052 commented Mar 8, 2023

https://rawcdn.githack.com/epi052/feroxbuster/2d381e7e057ce60c580b324dd36c9abaf30c2ec7/img/logo/logo.png

@aancw
Copy link
Contributor Author

aancw commented Mar 8, 2023

Thank you for your appreciation, I'm so honored to contribute this project. I will push the commit for new logo soon.

@epi052
Copy link
Owner

epi052 commented Mar 11, 2023

pushed 2.8.0 as part of testing this, all seemed to work. they say it goes through automated tasks and will eventually be available. I'll look into automating this some other time. for now, i'm ok with it just being a manual process

@epi052
Copy link
Owner

epi052 commented Mar 11, 2023

thanks again for all your help!

@epi052 epi052 merged commit c04bf4a into epi052:main Mar 11, 2023
@aancw aancw deleted the chocolatey branch March 11, 2023 14:31
@aancw
Copy link
Contributor Author

aancw commented Mar 11, 2023

Note: The checksum value in xml need to be updated with the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Chocolatey package
2 participants