-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement auto update feature #813
Conversation
started a review, should have it done tomorrow morning 🙏 |
first pass looked good! this is a really nice quality of life addition. I made some comments iwth request for edits, take your time with any response, and thank you! |
Okay. I will start to update the code |
This is after error handling and match condition for update
|
All requested change is resolved. Please review my change when you are available. Thank you. |
Looks great, tysm! merging |
@all-contributors add @aancw for ideas |
I've put up a pull request to add @aancw! 🎉 |
You're welcome. Sorry i was forgot about the updated test text that cause error in CI |
Fixes #812
For testing this feature, you need to clone my
update-package
branch and change the version in cargo.toml to previous version because the latest version is 2.9.0.Tested on x86_64-macos. Need tester for linux and windows.
Landing a Pull Request (PR)
Long form explanations of most of the items below can be found in the CONTRIBUTING guide.
Branching checklist
Static analysis checks
cargo fmt
clippy
checks pass when runningcargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
Documentation
docs
, as needed. The docs live in a separate repository. Update the appropriate pages at the links below.Additional Tests