Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load wordlist from url; change some defaults/fix some bugs #834

Merged
merged 11 commits into from
Mar 18, 2023

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Mar 17, 2023

closes #827
closes #835

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@epi052
Copy link
Owner Author

epi052 commented Mar 17, 2023

  • fixed divide by zero error
  • added check for force-recursion to dirlisting check

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.03 ⚠️

Comparison is base (b786578) 92.32% compared to head (d561e59) 92.30%.

❗ Current head d561e59 differs from pull request most recent head 46d0050. Consider uploading reports for the commit 46d0050 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   92.32%   92.30%   -0.03%     
==========================================
  Files          63       63              
  Lines       11413    11443      +30     
==========================================
+ Hits        10537    10562      +25     
- Misses        876      881       +5     
Impacted Files Coverage Δ
src/main.rs 93.07% <67.85%> (-1.38%) ⬇️
src/config/container.rs 96.94% <80.00%> (-0.18%) ⬇️
src/config/tests.rs 100.00% <100.00%> (ø)
src/config/utils.rs 98.13% <100.00%> (+0.05%) ⬆️
src/parser.rs 100.00% <100.00%> (ø)
src/scan_manager/tests.rs 98.44% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@epi052 epi052 merged commit 5d96658 into main Mar 18, 2023
@epi052 epi052 deleted the 827-load-wordlist-from-url branch March 18, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant