Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

935 fix scan menu range issue #936

Merged
merged 6 commits into from
Jul 11, 2023
Merged

935 fix scan menu range issue #936

merged 6 commits into from
Jul 11, 2023

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Jul 11, 2023

closes #935
closes #926
closes #905

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 26.66% and project coverage change: -0.07 ⚠️

Comparison is base (8d0614b) 92.72% compared to head (1c9235a) 92.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   92.72%   92.65%   -0.07%     
==========================================
  Files          63       63              
  Lines       12014    12025      +11     
==========================================
+ Hits        11140    11142       +2     
- Misses        874      883       +9     
Impacted Files Coverage Δ
src/scan_manager/tests.rs 98.44% <ø> (ø)
src/scan_manager/scan_container.rs 60.35% <23.07%> (-1.19%) ⬇️
src/scan_manager/scan.rs 87.89% <50.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@epi052 epi052 merged commit 0fb682c into main Jul 11, 2023
12 checks passed
@epi052 epi052 deleted the 935-fix-scan-menu-range-issue branch July 11, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant