Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mean and std have the same values in the checkpoints RGB #6

Closed
bguetarni opened this issue Dec 11, 2020 · 3 comments
Closed

mean and std have the same values in the checkpoints RGB #6

bguetarni opened this issue Dec 11, 2020 · 3 comments

Comments

@bguetarni
Copy link

Hi,
I downloaded the TSN (RGB) checkpoint to test it. After looking at the configuration attributes I saw that the mean and the std values for data pre-processing were actually the same. It is on purpose ?

If I do:
ckpt = torch.load("path/to/tosn_rgb.ckpt", map_location=lambda storage, loc: storage)
cfg = OmegaConf.create(ckpt["hyper_parameters"])
OmegaConf.set_struct(cfg, False)
cfg.data._root_gulp_dir = os.getcwd()
print(cfg.data.preprocessing.mean)
print(cfg.data.preprocessing.std)

Then I have:
'mean': [0.485, 0.456, 0.406]
'std': [0.485, 0.456, 0.406]

Actually after looking at the checkpoints of TRN and TMN I saw that they also have this problem.
Thanks.

@willprice
Copy link
Member

Yes, that looks wrong to me, I'm fairly sure I didn't train them that way; good catch! I think I must have messed up the checkpoint conversion.

The standard deviation should be [0.229, 0.224, 0.225] for RGB models and the mean of that list for flow models.
Sorry about that.

I'll fix the checkpoints on dropbox by the end of next Tuesday and upload new checkpoints.

Thank you for the bug report.

@willprice
Copy link
Member

Hi @bguetarni,
This has been rectified in d58e695 and the models have also been updated, you should find that if you redownload them (same URLs as before), then the std property will be correct.
Thanks again for raising the issue!

@willprice
Copy link
Member

Hi @bguetarni,
It turns out I was mistaken and I did in fact train these models with the same mean and std, see #8 for more details. I've reverted the checkpoints to their original variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants