Skip to content
This repository has been archived by the owner on Feb 14, 2022. It is now read-only.

Implement auto-complete for hero select #94

Merged
merged 10 commits into from Mar 13, 2019
Merged

Implement auto-complete for hero select #94

merged 10 commits into from Mar 13, 2019

Conversation

stocky37
Copy link
Collaborator

@stocky37 stocky37 commented Mar 10, 2019

Required to properly change over to new api implementation (#93)

To Do

  • Fix bug with null value when clearing
  • Fix default value on initial load
  • Fix bug where it scrolls to page bottom when selecting items from menu with arrow keys

@stocky37
Copy link
Collaborator Author

stocky37 commented Mar 12, 2019

Scrolling bug is hidden when removing position="static" is removed from the toolbar. It appears the page still scrolls but this has less noticeable effect since the toolbar follows the page down.

@stocky37
Copy link
Collaborator Author

Also want a hierarchy of sorts for the way I have the autocomplete implemented, where I have a re-usable basic autocomplete component that uses a standard-ish api to MUI inputs.

@stocky37
Copy link
Collaborator Author

stocky37 commented Mar 12, 2019

For the default value::

defaultSelectedItem={{ label: '4-LOM', value: 0 }}

This will change if/when mui-downshift upgrades to downshift v3

@stocky37 stocky37 merged commit 988ca30 into master Mar 13, 2019
@stocky37 stocky37 deleted the mui-downshift branch June 11, 2019 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant