Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpickr wrapper #178

Merged
merged 8 commits into from May 3, 2018
Merged

Flatpickr wrapper #178

merged 8 commits into from May 3, 2018

Conversation

asvae
Copy link
Contributor

@asvae asvae commented Apr 20, 2018

Docs

Notable issues:

  • No today styling
  • add .vuestic-date-picker class both to component and sass
  • rm tooltip's arrow
  • remove white border
  • Please move datepickers to a separate widget on Forms Elements page in a separate widget below 'Inputs widget'
  • input label doesn't go down

@asvae asvae requested a review from smartapant April 20, 2018 21:45
@@ -0,0 +1,263 @@
<template>
<vue-flatpickr-component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add .vuestic-date-picker class both to component and sass

}

.flatpickr-days {
width: $daySize * 7 + $dayPadding * 6 + $borderPadding * 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2018-04-27 at 4 55 04 pm
padding right is strange

}
}

.flatpickr-days {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm tooltip's arrow
screen shot 2018-04-27 at 4 55 41 pm

}
}

.flatpickr-days {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange safari focus bug
screen shot 2018-04-27 at 4 54 58 pm

@@ -0,0 +1,93 @@
<template>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move datepickers to a separate widget on Forms Elements page in a separate widget below 'Inputs widget'

<div class="col-lg-4">
<vuestic-widget :headerText="$t('dateTimePicker.multiple')">
<div class="form-group">
<div class="input-group">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label doesn't go down
screen shot 2018-04-27 at 5 09 15 pm

@smartapant
Copy link
Contributor

@asvae

  1. fix issues
  2. squash & merge into master
  3. ask @alexanderrudnik to reload Vuestic's server
  4. don't close the issue, ask @xx13 further design review after server is updated

@asvae asvae merged commit 4823cdb into epicmaxco:master May 3, 2018
@asvae asvae deleted the flatpickr-wrapper branch May 3, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants