Skip to content

Commit

Permalink
fix(VaDataTable): fix double border from head(#4147) (#4202)
Browse files Browse the repository at this point in the history
* fix(VaDataTable): fix double border from head(#4147)

* fix(data-table): remove thead box-shadow

---------

Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com>
  • Loading branch information
gweesin and m0ksem committed Apr 8, 2024
1 parent 37aac3a commit f3ddfd2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 1 addition & 3 deletions packages/ui/src/components/va-data-table/VaDataTable.vue
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,6 @@ const cellData = (cellData: DataTableCell, internalColumnData: DataTableColumnIn
th {
border-bottom: none;
box-shadow: var(--va-data-table-thead-border-bottom-shadow);
}
&--sticky {
Expand All @@ -477,11 +476,10 @@ const cellData = (cellData: DataTableCell, internalColumnData: DataTableColumnIn
.va-data-table__table-tfoot {
color: var(--va-data-table-tfoot-color);
border-top: var(--va-data-table-thead-border);
border-top: var(--va-data-table-tfoot-border, var(--va-data-table-thead-border));
th {
border-bottom: none;
box-shadow: var(--va-data-table-thead-border-top-shadow);
}
&--sticky {
Expand Down
3 changes: 1 addition & 2 deletions packages/ui/src/components/va-data-table/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
--va-data-table-thead-text-transform: uppercase;
--va-data-table-thead-letter-spacing: 0.6px;
--va-data-table-thead-border: 1px solid var(--va-background-border);
--va-data-table-thead-border-top-shadow: inset 0 1px 0 0 var(--va-background-border);
--va-data-table-thead-border-bottom-shadow: inset 0 -1px 0 0 var(--va-background-border);
--va-data-table-tfoot-border: unset;
--va-data-table-height: unset;
--va-data-table-max-height: unset;
--va-data-table-thead-color: currentColor;
Expand Down

0 comments on commit f3ddfd2

Please sign in to comment.