Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getCurrentInstance()?.props in composables #1576

Closed
2 tasks
m0ksem opened this issue Mar 17, 2022 · 1 comment
Closed
2 tasks

Use getCurrentInstance()?.props in composables #1576

m0ksem opened this issue Mar 17, 2022 · 1 comment
Assignees
@aluarius
Labels
refactoring Prettify code without introducing new features research Requires research

Comments

@m0ksem
Copy link
Collaborator

m0ksem commented Mar 17, 2022 •
edited by asvae
Loading

We have lots of compostables, that require props and emit. Actually, app context can be accessible from getCurrentInstance().

Other

  • Probably mostly useful for emits.
  • Could be useful for passing slots to composables.
  • Check how it's done in h3, vue-use, nuxt.
  • Needs investigation of possible benefits we can get from this.
@m0ksem m0ksem added refactoring Prettify code without introducing new features LOW PRIORITY labels Mar 17, 2022
@m0ksem m0ksem mentioned this issue Mar 23, 2022
Closed
7 tasks
@asvae asvae added research Requires research and removed LOW PRIORITY labels Mar 31, 2022
@aluarius aluarius self-assigned this Apr 11, 2022
@m0ksem m0ksem mentioned this issue May 5, 2022
Closed
@m0ksem
Copy link
Collaborator Author

m0ksem commented Jul 8, 2022

Let's not use getCurrentInstance since it has been removed from vue3 docs :(

@m0ksem m0ksem closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aluarius aluarius

Labels
refactoring Prettify code without introducing new features research Requires research
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asvae @m0ksem @aluarius