Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange border-radii for collapses #2021

Closed
smellyshovel opened this issue Jun 29, 2022 · 3 comments · Fixed by #2024
Closed

Strange border-radii for collapses #2021

smellyshovel opened this issue Jun 29, 2022 · 3 comments · Fixed by #2024
Assignees
@aluarius
Labels
BUG Something isn't working external Reported by external contributor and handled with priority
Milestone
1.4.6

Comments

@smellyshovel
Copy link
Member

UI v 1.2.x -> 1.4.2 comparison. Strangely-looking and behaving border radii for the collapse elements.

Old
old-radii

New
new-radii

It feels to me like it would make much more sense if there would be no border-radius at the bottom when the collapse is opened and the same bottom radius as at the top when it's closed. I.e. vice-verse from what it's now.
@smellyshovel smellyshovel added BUG Something isn't working external Reported by external contributor and handled with priority labels Jun 29, 2022
@smellyshovel smellyshovel mentioned this issue Jun 29, 2022
Closed
39 tasks
@aluarius aluarius self-assigned this Jun 29, 2022
@aluarius aluarius mentioned this issue Jun 29, 2022
Merged
4 tasks
m0ksem pushed a commit that referenced this issue Jun 30, 2022
@aluarius
[#2009] [#2015] [#2016] [#2021] [#2023] minor bugfixes (#2024)
58c757e 
* small issues fixes

* 2009 issue bugfix

* accordion visual fixes (according to Vasily request)

* review updates
@m0ksem
Copy link
Contributor

m0ksem commented Jun 30, 2022

@xx13, how we can deal with it? Do we even need colored background?

@m0ksem m0ksem reopened this Jun 30, 2022
@aluarius
Copy link
Contributor

aluarius commented Jun 30, 2022 •
edited

@xx13, how we can deal with it? Do we even need colored background?

He has told about colored background, but i tried it (with background preset color) and that looks weird in some cases, so i decided to leave it until redesign.

@smellyshovel
Copy link
Member Author

@aluarius what about the radii? Will there be any fixes until the patch release?

@m0ksem m0ksem added this to the 1.4.6 (current) milestone Jul 2, 2022
@m0ksem m0ksem closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aluarius aluarius

Labels
BUG Something isn't working external Reported by external contributor and handled with priority
Projects
None yet
Milestone
1.4.6
Development

Successfully merging a pull request may close this issue.

[#2009] [#2015] [#2016] [#2021] [#2023] minor bugfixes aluarius/vuestic-ui
3 participants
@smellyshovel @m0ksem @aluarius