Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dropdown props to DateInput, TimeInput, Select #2237

Closed
3 tasks
m0ksem opened this issue Aug 12, 2022 · 2 comments · Fixed by #2445
Closed
3 tasks

Add dropdown props to DateInput, TimeInput, Select #2237

m0ksem opened this issue Aug 12, 2022 · 2 comments · Fixed by #2445
Assignees
Labels
BUG Something isn't working

Comments

@m0ksem
Copy link
Contributor

m0ksem commented Aug 12, 2022

  • VaDateInput
  • VaSelect
  • VaTimeInput
@m0ksem m0ksem added the BUG Something isn't working label Aug 12, 2022
@thetejasmagade
Copy link

Your issue is not that much clear. Can, you please ellaborate more on this?

@m0ksem
Copy link
Contributor Author

m0ksem commented Aug 15, 2022

Your issue is not that much clear. Can, you please ellaborate more on this?

Hi. We have some functions to proxy component props from child to parent. It is called something like extractComponentProps.

For example, we already extract props from VaInput and pass it as VaDateInput props. This makes user able to modify input props.

The same thing must be done with VaDropdown, which used in VaDateInput. This way user will be able to pass props like placement, prevent-overflow, etc. to dropdown.

<va-date-input placement="top" color="#f0f" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants