Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1829] [#1975] VaPopup deleted, composables index, useColor/useColors refactoring #1997

Merged
merged 5 commits into from Jun 27, 2022

Conversation

aluarius
Copy link
Contributor

Close: #1829
Close: #1975

Description

VaPopup component was removed, created composables index (for more clear composables mass import), useColors hook moved to composables, useColor hook deleted, changes to associated components and hooks, minor refactoring.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

…secolors hooks refactoring, vapopup deleted, minor refactoring
# Conflicts:
#	packages/ui/src/components/va-infinite-scroll/VaInfiniteScroll.vue
#	packages/ui/src/components/va-inner-loading/VaInnerLoading.vue
#	packages/ui/src/components/va-input/VaInput.vue
#	packages/ui/src/components/va-input/components/VaInputWrapper.vue
#	packages/ui/src/components/va-input/components/VaMessageList/VaMessageList.vue
#	packages/ui/src/components/va-input/components/VaMessageListWrapper.vue
#	packages/ui/src/components/va-input/components/VaTextarea/VaTextarea.vue
#	packages/ui/src/components/va-modal/VaModal.vue
#	packages/ui/src/components/va-navbar/VaNavbar.vue
#	packages/ui/src/components/va-pagination/VaPagination.vue
#	packages/ui/src/components/va-progress-bar/VaProgressBar.vue
@aluarius aluarius changed the title Feat/composables refactoring [#1829] [#1975] VaPopup deleted, composables index, useColor/useColors refactoring Jun 23, 2022
@m0ksem m0ksem added this to the 1.4.3 milestone Jun 23, 2022
packages/ui/src/composables/index.ts Outdated Show resolved Hide resolved
# Conflicts:
#	packages/ui/src/components/va-badge/VaBadge.vue
#	packages/ui/src/components/va-option-list/VaOptionList.vue
#	packages/ui/src/components/va-progress-circle/VaProgressCircle.vue
#	packages/ui/src/components/va-radio/VaRadio.vue
#	packages/ui/src/components/va-rating/VaRating.vue
#	packages/ui/src/components/va-rating/components/VaRatingItem/VaRatingItem.vue
#	packages/ui/src/components/va-rating/components/VaRatingItemNumberButton.vue
#	packages/ui/src/components/va-rating/hooks/useRating.ts
#	packages/ui/src/components/va-rating/hooks/useVaRatingColors.ts
#	packages/ui/src/components/va-select/VaSelect.vue
#	packages/ui/src/components/va-select/VaSelectOptionList/VaSelectOptionList.vue
#	packages/ui/src/components/va-sidebar/VaSidebar.vue
#	packages/ui/src/components/va-sidebar/VaSidebarItem/VaSidebarItem.vue
#	packages/ui/src/components/va-slider/VaSlider.vue
#	packages/ui/src/components/va-switch/VaSwitch.vue
#	packages/ui/src/components/va-tabs/VaTab/VaTab.vue
#	packages/ui/src/components/va-tabs/VaTabs.vue
#	packages/ui/src/components/va-time-input/VaTimeInput.vue
#	packages/ui/src/components/va-time-picker/VaTimePicker.vue
#	packages/ui/src/components/va-time-picker/components/VaTimePickerColumn.vue
#	packages/ui/src/components/va-timeline/VaTimelineSeparator/VaTimelineSeparator.vue
#	packages/ui/src/components/va-toast/VaToast.vue
#	packages/ui/src/composables/useColor.ts
#	packages/ui/src/composables/useTextColor.ts
Copy link
Contributor

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My dark theme pr will require fixing a lot of conflicts...

@aluarius aluarius merged commit d413d9c into epicmaxco:develop Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove VaPopup Make composables/index
3 participants