Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1888] Fix VaDataTable selection with updated items (add items-track-by prop) #2025

Merged
merged 8 commits into from Jun 30, 2022
Merged

[#1888] Fix VaDataTable selection with updated items (add items-track-by prop) #2025

merged 8 commits into from Jun 30, 2022

Conversation

RVitaly1978
Copy link
Contributor

Description

close #1888

changes:

  • add items-track-by prop
  • fix useSelectableRows
  • update docs examples
  • update locales

chrome-capture-2022-5-29

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@RVitaly1978 RVitaly1978 added the feature Something useful to end user label Jun 29, 2022
@RVitaly1978 RVitaly1978 self-assigned this Jun 29, 2022
@RVitaly1978 RVitaly1978 added this to the 1.4.5 (current) milestone Jun 29, 2022
@m0ksem m0ksem requested review from Derranion and removed request for m0ksem June 29, 2022 23:10
@RVitaly1978 RVitaly1978 merged commit a243b4a into epicmaxco:develop Jun 30, 2022
@RVitaly1978 RVitaly1978 deleted the fix/table-track-by branch June 30, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustem-nasyrov rustem-nasyrov rustem-nasyrov approved these changes

@aluarius aluarius aluarius approved these changes

@Derranion Derranion Awaiting requested review from Derranion

Assignees

@RVitaly1978 RVitaly1978

Labels
feature Something useful to end user
Projects
None yet
Milestone
1.4.5
Development

Successfully merging this pull request may close these issues.

VaDataTable rows (of type TableRow) are generated based on initialIndex instead of id
3 participants
@RVitaly1978 @rustem-nasyrov @aluarius