VaCounter validation #2113
Merged
VaCounter validation #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aluarius
reviewed
Jul 19, 2022
aluarius
approved these changes
Jul 19, 2022
RVitaly1978
requested changes
Jul 20, 2022
| @@ -294,6 +295,8 @@ export default defineComponent({ | |||
|
|
|||
| const marginComputed = computed(() => safeCSSLength(props.margins)) | |||
|
|
|||
| validateCounter(props.modelValue, props.step, props.min, props.max) | |||
There was a problem hiding this comment.
This checks the props only once. But props can change dynamically
damirJa
force-pushed
the
feat/va-counter-validation
branch
from
1512722
to
07c5797
Compare
Co-authored-by: Oleg <64714442+aluarius@users.noreply.github.com>
Co-authored-by: Vitaly <vitaly.raichev@epicmax.co>
Co-authored-by: Vitaly <vitaly.raichev@epicmax.co>
Co-authored-by: Vitaly <vitaly.raichev@epicmax.co>
Co-authored-by: Vitaly <vitaly.raichev@epicmax.co>
… feat/va-counter-validation
RVitaly1978
approved these changes
Sep 14, 2022
m0ksem
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1976
Description
Types of changes