Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2292] virtual scroller component #2331

Merged
merged 10 commits into from
Sep 9, 2022
Merged

[#2292] virtual scroller component #2331

merged 10 commits into from
Sep 9, 2022

Conversation

aluarius
Copy link
Contributor

Closes: #2292

Description

Virtual scroller component implementation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@aluarius aluarius self-assigned this Aug 31, 2022
@aluarius aluarius added the component Is a new component or part of existing one label Aug 31, 2022
@aluarius aluarius added this to the 1.5.0 milestone Aug 31, 2022
rustem-nasyrov
rustem-nasyrov requested changes Sep 1, 2022
View reviewed changes
packages/docs/src/locales/en/en.json Outdated Show resolved Hide resolved
packages/docs/src/locales/en/en.json Outdated Show resolved Hide resolved
packages/docs/src/locales/en/en.json Outdated Show resolved Hide resolved
packages/docs/src/locales/en/en.json Outdated Show resolved Hide resolved
packages/docs/src/locales/en/en.json Outdated Show resolved Hide resolved
packages/docs/src/page-configs/ui-elements/virtual-scroller/examples/Bench.vue Outdated Show resolved Hide resolved
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.demo.vue Outdated Show resolved Hide resolved
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.vue Outdated Show resolved Hide resolved
packages/ui/src/components/va-virtual-scroller/useVirtualScrollerSizes.ts Outdated Show resolved Hide resolved
packages/ui/src/components/va-virtual-scroller/useVirtualScrollerSizes.ts Outdated Show resolved Hide resolved
@asvae
Copy link
Member

asvae commented Sep 5, 2022

We're pretty close!

@aluarius
refactor: review suggestions + common refactoring
e2b1674
@aluarius
Merge branch 'release/1.5.0' into feat/2292-virtual-scroller-component
6a3992c 
# Conflicts:
#	packages/docs/src/locales/en/en.json
#	packages/docs/src/locales/ru/ru.json
#	packages/ui/src/components/index.ts
#	packages/ui/src/vuestic-plugin/vuestic-components.ts
@aluarius
refactor: review suggestions + common refactoring
289caef
@aluarius aluarius requested a review from asvae September 6, 2022 13:34
asvae
asvae approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rustem-nasyrov
Copy link
Collaborator

rustem-nasyrov commented Sep 8, 2022 •
edited by aluarius
Loading

Screenshot 2022-09-08 at 18 20 27 Screenshot 2022-09-08 at 18 25 40

I think the scrollbar track should be transparent.

@aluarius aluarius mentioned this pull request Sep 9, 2022
Closed
@aluarius aluarius merged commit 2881ccd into epicmaxco:release/1.5.0 Sep 9, 2022
@aluarius aluarius mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustem-nasyrov rustem-nasyrov rustem-nasyrov requested changes

@asvae asvae asvae approved these changes

@m0ksem m0ksem Awaiting requested review from m0ksem

@Azgiliat Azgiliat Awaiting requested review from Azgiliat

@RVitaly1978 RVitaly1978 Awaiting requested review from RVitaly1978

Assignees

@aluarius aluarius

Labels
component Is a new component or part of existing one
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aluarius @asvae @rustem-nasyrov