Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed VaButtonDropdown spacing. #2519

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Fixed VaButtonDropdown spacing. #2519

merged 3 commits into from
Oct 26, 2022

Conversation

Sadnessa
Copy link
Contributor

Description

Closed #2505.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

rustem-nasyrov
rustem-nasyrov reviewed Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@rustem-nasyrov rustem-nasyrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Imo, values shouldn't be symmetrical to button's padding-x, because it will look too much apart of the button content. See screenshot below. Lets discuss it, @m0ksem, @asvae.
image

@m0ksem m0ksem self-requested a review October 15, 2022 21:38
@m0ksem m0ksem added this to the 1.5.0 (current) milestone Oct 15, 2022
@m0ksem m0ksem requested a review from xx13 October 17, 2022 12:46
m0ksem
m0ksem reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for default VaButtonDropdown, but looks weird with split prop.

image

Might need a separate solution for split buttons.

@rustem-nasyrov rustem-nasyrov self-assigned this Oct 25, 2022
@m0ksem m0ksem merged commit a5ddc3b into epicmaxco:develop Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustem-nasyrov rustem-nasyrov rustem-nasyrov left review comments

@m0ksem m0ksem m0ksem approved these changes

@xx13 xx13 Awaiting requested review from xx13

Assignees

@rustem-nasyrov rustem-nasyrov

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

VaButtonDropdown awful spacing
3 participants
@Sadnessa @m0ksem @rustem-nasyrov