fix: css variables names #2524
Merged
fix: css variables names #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will we fix it? Or leave it as is? Checkboxdevelop: |
|
VaDivider somehow became barely visible. Screenshotsdevelop:
production:
|
| @@ -3,6 +3,7 @@ | |||
| --va-progress-bar-position: relative; | |||
| --va-progress-bar-overflow: hidden; | |||
| --va-progress-bar-height: 0.5rem; | |||
| --va-progress-bar-border-radius: 9999999px; | |||
There was a problem hiding this comment.
What if we do it like this? It's still rounded.
Suggested change
| --va-progress-bar-border-radius: 9999999px; | |
| --va-progress-bar-border-radius: var(--va-progress-bar-height); |
rustem-nasyrov
requested changes
Oct 14, 2022
rustem-nasyrov
approved these changes
Oct 14, 2022
m0ksem
added a commit
to m0ksem/vuestic-ui
that referenced
this pull request
Oct 17, 2022
* fix: css variables names * fix: review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move useless css variables away, so user will not be overwhelmed with amount of CSS variables.
In most cases it is
positionordisplaywhich user shouldn't change, cuz it will break component.closes #2276