Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo link for the Header logo (Docs) #2694

Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/docs/src/components/header/Header.vue
Expand Up @@ -7,14 +7,14 @@
:minimized="isSidebarVisible"
@toggleSidebar="toggleSidebar"
/>
<router-link :to="currentRoute" custom v-slot="{ href }">
<a :href="href" aria-label="go to the documentation main page">
<router-link :to="overviewLink.to" custom v-slot="{ navigate, href }">
<a :href="href" :aria-label="overviewLink.text" :title="overviewLink.text">
<vuestic-logo
class="header__logo__wrapper__image"
height="30"
width="150"
aria-hidden="true"
@click="$router.go(0)"
@click="navigate"
/>
</a>
</router-link>
Expand Down Expand Up @@ -74,6 +74,13 @@ export default class Header extends mixins(PropsMixin) {
return this.$root?.$i18n?.locale
}

get overviewLink () {
return {
text: this.$t('menu.overview'),
to: `/${this.locale}/introduction/overview`,
}
}

get links () {
return [
{
Expand All @@ -92,10 +99,6 @@ export default class Header extends mixins(PropsMixin) {
]
}

get currentRoute () {
return { to: this.$route.path }
}

toggleSidebar () {
this.$emit('update:isSidebarVisible', !this.isSidebarVisible)
}
Expand Down