Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3036] Round VaButton #3278

Merged
merged 4 commits into from
Apr 5, 2023
Merged

[#3036] Round VaButton #3278

merged 4 commits into from
Apr 5, 2023

Conversation

RVitaly1978
Copy link
Member

@RVitaly1978 RVitaly1978 commented Mar 29, 2023 •
edited
Loading

Description

close #3036
close #2922

  • fix button styles
  • set icons (.va-button__left-icon and .va-button__right-icon) the same line-height as in .va-button__content
  • tweak docs and demo examples
screenshots

image

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@RVitaly1978 RVitaly1978 self-assigned this Mar 29, 2023
@RVitaly1978 RVitaly1978 added the BUG Something isn't working label Mar 29, 2023
@m0ksem m0ksem merged commit 1bef6b7 into epicmaxco:develop Apr 5, 2023
@RVitaly1978 RVitaly1978 deleted the 3036-round-button branch April 5, 2023 11:30
m0ksem pushed a commit to asvae/vuestic-ui that referenced this pull request Apr 6, 2023
@RVitaly1978 @m0ksem
[epicmaxco#3036] Round VaButton (epicmaxco#3278)
90a9a27 
* fix(epicmaxco#3036): update button and icons styles

* fix(epicmaxco#3036): tweak docs example

* fix(epicmaxco#3036): demo examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

@rustem-nasyrov rustem-nasyrov rustem-nasyrov approved these changes

Assignees

@RVitaly1978 RVitaly1978

Labels
BUG Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Round button not round VaButtonDropdown's size is bigger than VaButton's size.
3 participants
@RVitaly1978 @m0ksem @rustem-nasyrov