Refactor vaTextarea autosize calculations to use scrollHeight instead of newline characters #4146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old
rows
calculations used the number of new line characters\n
to automatically calculate the number ofrows
for thetextarea
. This becomes a problem when long paragraphs on a single line wrap around but thetextarea
doesn't recognise the newrows
. I've taken inspiration from Vuetify and refactored theautosize
calculations to usescrollheight
in an invisibletextarea
to calculate therows
instead.Markup:
Types of changes