Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Com: Adjust epicsAtomic conditionals for GCC #180

Closed
wants to merge 1 commit into from

Conversation

mdavidsaver
Copy link
Member

@anjohnson
Copy link
Member

Thanks for the sorely needed explanatory comments.

An aside, but I discovered recently that the preprocessor’s defined() function is only actually valid when it appears directly inside a #if statement, although gcc and most other compilers have always allowed it in macros that get expanded in one. Recent versions of clang actually warn about UB when they see that, although they do still honor it.

@AppVeyorBot
Copy link

@mdavidsaver mdavidsaver marked this pull request as ready for review July 6, 2021 18:25
@mdavidsaver
Copy link
Member Author

Now that 7.0.6 is out the door, I'd like to merge this.

@mdavidsaver
Copy link
Member Author

Core meeting review: acceptable

@anjohnson
Copy link
Member

Working on CLANG version, race to who gets to merge it first...

@anjohnson
Copy link
Member

I'm not sure that all the macro magic that sets GCC_ATOMIC_INTRINSICS_AVAIL_SYNC is correct here, please don't merge.

I have a version with it fixed though (I think) and with the common-with-clang implementation too. I'm supposed to be on vacation this afternoon though (what's left of it) so it'll be sometime next week before I'm ready to push that.

@anjohnson anjohnson mentioned this pull request Aug 2, 2021
@mdavidsaver
Copy link
Member Author

Superseded by #192

@mdavidsaver mdavidsaver closed this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants