Fix issue when osdThreadGetTimer() called from non EPICS threads #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not calling epicsThreadImplicitCreate() in such cases
|
Maybe I do a separate PR for the bigger refactor and branch that PR off 3.15 for it to be upmerged later? |
|
❌ Build EPICS Base 7 base-7.0-387 failed (commit a70800d5cf by @FreddieAkeroyd) |
|
Closing this, I'll be merging up the refactor PR from 3.15 instead shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported in https://epics.anl.gov/tech-talk/2021/msg01691.php
The function need to use epicsThreadImplicitCreate() to handle the case of if it is called from a non EPICS thread - this approach is already used in epicsThreadSuspendSelf, epicsThreadGetPrioritySelf, epicsThreadGetIdSelf and epicsThreadGetNameSelf.
This repeated logic should probably be moved into a separate function, but maybe that is for a separate PR?