COMMANDLINE_LIBRARY fallback to $(wildcard $(GNU_DIR) #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdavidsaver
force-pushed
the
auto-readline-fallback
branch
from
628cb12
to
212c86d
Compare
|
❌ Build EPICS Base 7 base-7.0-686 failed (commit aa7fd7944b by @mdavidsaver) |
|
Core Group 12/21: Low risk, apply. |
|
Applied as 52cc684 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to restore auto-detect with older compilers (eg. GCC 4.8 circa RHEL7). cf #254
https://epics.anl.gov/core-talk/2022/msg00381.php
This PR is not a simple revert. For simplicity, the older
$(wildcard)logic is placed in an#elseclause withinconfigure/toolchain.c(which is really a makefile) where it will be run for all targets, not just the selectlinux*targets where it was previously found (cf. 42c7dbc).As this change tests for
GNU_DIRbeing not-empty, I don't think this would effect MSVC or RTEMS targets. It might effect linux, apple, solaris, cygwin, mingw, and vxworks. Where it could cause breakage if some (misconfigured) target has GNU_DIR set incorrectly (eg. for the host of a cross build), or if the headers are detect but the library is not in the search path.