fix problem with commands returning multiple trailing newlines #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build EPICS Base 7 base-7.0-896 failed (commit 5ceca96f9b by @dirk-zimoch) |
|
Core Group: @ralphlange Were you going to test this on Darcs, just to show that the generalized setting change hasn't broken that VCS? If not we're happy with this. |
|
@ralphlange ping. |
(setting $/='' breaks reading multi-line into an array)
|
With that change - fine for rebase-and-merge. |
|
❌ Build EPICS Base 7 base-7.0-1052 failed (commit 31a71141ec by @ralphlange) |
|
✅ Build EPICS Base 7 base-7.0-1052 completed (commit 31a71141ec by @ralphlange) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
git show -s --format=%ci HEADmay output more than one trailing newline under some circumstances (git version 1.8.3.1 if the commit is a merge). This leads to invalid C-code in epicsVCS.h if not all trailing newlines are removed. The default forchompis to remove only one newline, unless one sets$/='';first. https://perldoc.perl.org/functions/chomp.