Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I noted on lp:1896295,
epicsTimeDiffInSeconds()
andclass epicsTime
which underpins it, do not correctly handle 32-bit overflow on targets wheresizeof(long)==8
(eg. Linux).This PR changes 'class epicsTime' to use
epicsUInt32
to match 'struct epicsTimeStamp', and tries to fix the various places in epicsTime.cpp where overflow is detected. This passes existing tests, and a new test ofepicsTimeDiffInSeconds()
overflow.I'm not certain that this is the best approach though. I think a rewrite would be better. Specifically to make
class epicsTime
a wrapper aroundstruct epicsTimeStamp
.