Skip to content

Commit

Permalink
no "invalid bit-set length"
Browse files Browse the repository at this point in the history
Not actually an error case as BitSet storage is compacted.
  • Loading branch information
mdavidsaver committed Mar 18, 2020
1 parent 245a09a commit 4ef9c11
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions src/remoteClient/clientContextImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ class BaseRequestImpl :
static const Status otherRequestPendingStatus;
static const Status invalidPutStructureStatus;
static const Status invalidPutArrayStatus;
static const Status invalidBitSetLengthStatus;
static const Status pvRequestNull;

static BitSet::shared_pointer createBitSetFor(
Expand Down Expand Up @@ -436,7 +435,6 @@ const Status BaseRequestImpl::channelDestroyed(Status::STATUSTYPE_ERROR, "channe
const Status BaseRequestImpl::otherRequestPendingStatus(Status::STATUSTYPE_ERROR, "other request pending");
const Status BaseRequestImpl::invalidPutStructureStatus(Status::STATUSTYPE_ERROR, "incompatible put structure");
const Status BaseRequestImpl::invalidPutArrayStatus(Status::STATUSTYPE_ERROR, "incompatible put array");
const Status BaseRequestImpl::invalidBitSetLengthStatus(Status::STATUSTYPE_ERROR, "invalid bit-set length");
const Status BaseRequestImpl::pvRequestNull(Status::STATUSTYPE_ERROR, "pvRequest == 0");


Expand Down Expand Up @@ -925,12 +923,6 @@ class ChannelPutImpl :
return;
}

if (pvPutBitSet->size() < m_bitSet->size())
{
EXCEPTION_GUARD3(m_callback, cb, cb->putDone(invalidBitSetLengthStatus, thisPtr));
return;
}

if (!startRequest(m_lastRequest.get() ? QOS_DESTROY : QOS_DEFAULT)) {
EXCEPTION_GUARD3(m_callback, cb, cb->putDone(otherRequestPendingStatus, thisPtr));
return;
Expand Down Expand Up @@ -1175,12 +1167,6 @@ class ChannelPutGetImpl :
return;
}

if (bitSet->size() < m_putDataBitSet->size())
{
EXCEPTION_GUARD3(m_callback, cb, cb->putGetDone(invalidBitSetLengthStatus, thisPtr, PVStructurePtr(), BitSetPtr()));
return;
}

if (!startRequest(m_lastRequest.get() ? QOS_DESTROY : QOS_DEFAULT)) {
EXCEPTION_GUARD3(m_callback, cb, cb->putGetDone(otherRequestPendingStatus, thisPtr, PVStructurePtr(), BitSetPtr()));
return;
Expand Down

0 comments on commit 4ef9c11

Please sign in to comment.