New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple bugs #91

Merged

mdavidsaver merged 2 commits into epics-base:master from JJL772:misc-fixes

Aug 7, 2023

Contributor

JJL772 commented Jul 17, 2023 •

edited

Loading

These were issues reported by clang-tidy as I was running that on epics-base.

AnyScalar::bufferUnsafe() was returning a pointer to the data of an std::string living on the stack.
ostringstream::str() returns std::string by value, so we can't keep a pointer to its data without first turning it into an lvalue.
split should take the string as a reference to avoid unnecessary copies.
Added noexcept to the move ctor/assignment of AnyScalar

JJL772 added 2 commits

July 17, 2023 15:09


          Don't return local copy of std::string in AnyScalar::bufferUnsafe

a6ef7cc


          Fix use-after-destroy in epicsRefSnapshopCurrent

e1ea65a

AppVeyorBot commented Jul 18, 2023

✅ Build pvDataCPP 1.0.35 completed (commit c3fa20fd53 by @JJL772)

mdavidsaver merged commit eac2a8e into epics-base:master

24 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment