Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collections of Entities inside of Definitions #216

Merged
merged 24 commits into from
May 15, 2024
Merged

Add collections of Entities inside of Definitions #216

merged 24 commits into from
May 15, 2024

Commits on May 9, 2024

  1. add CollectionDefinition and refactor stage 1

    @gilesknap
    gilesknap committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d0bb484 View commit details
    Browse the repository at this point in the history

  2. refactor 2

    @gilesknap
    gilesknap committed May 9, 2024
    Configuration menu
    Copy the full SHA
    3c3741a View commit details
    Browse the repository at this point in the history

  3. refactor 3

    @gilesknap
    gilesknap committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7e68b3f View commit details
    Browse the repository at this point in the history

  4. make support.defs = [Definition|CollectionDefinition]

    @gilesknap
    gilesknap committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a6e9848 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. allow object ids in Arg defaults

    @gilesknap
    gilesknap committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7674437 View commit details
    Browse the repository at this point in the history

  2. first pass of SubEntity implementation

    @gilesknap
    gilesknap committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5f4f435 View commit details
    Browse the repository at this point in the history

  3. combine CollectionDefs and Defs in make_entity_models

    @gilesknap
    gilesknap committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4002584 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. move model functions into entity_model

    @gilesknap
    gilesknap committed May 11, 2024
    Configuration menu
    Copy the full SHA
    7cb291c View commit details
    Browse the repository at this point in the history

  2. move entity_model functions into IocFactory class

    @gilesknap
    gilesknap committed May 11, 2024
    Configuration menu
    Copy the full SHA
    e066669 View commit details
    Browse the repository at this point in the history

  3. tests passing but SubEntity Args still need work

    @gilesknap
    gilesknap committed May 11, 2024
    Configuration menu
    Copy the full SHA
    65554c1 View commit details
    Browse the repository at this point in the history

  4. CollectionDefinition fully working

    @gilesknap
    gilesknap committed May 11, 2024
    Configuration menu
    Copy the full SHA
    e3fa27a View commit details
    Browse the repository at this point in the history

  5. merge Definition and CollectionDefinition back into Definition

    @gilesknap
    gilesknap committed May 11, 2024
    Configuration menu
    Copy the full SHA
    f941f3c View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. demonstrate yaml anchors and aliases in quadem test

    @gilesknap
    gilesknap committed May 12, 2024
    Configuration menu
    Copy the full SHA
    338b70a View commit details
    Browse the repository at this point in the history

  2. support recursive SubEntities

    @gilesknap
    gilesknap committed May 12, 2024
    Configuration menu
    Copy the full SHA
    7e882f8 View commit details
    Browse the repository at this point in the history

  3. simplify Entity Model validator

    @gilesknap
    gilesknap committed May 12, 2024
    Configuration menu
    Copy the full SHA
    a1631b6 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. refactor parts of ioc_factory into entity_factory 

    This is a result of the PR review by Gary. Some
other minor review points are also addressed.

Fix up the rest of the tests and remaining PR
comments will be in the next commit.
    @gilesknap
    gilesknap committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c3892df View commit details
    Browse the repository at this point in the history

  2. update remaining tests to work with refactor

    @gilesknap
    gilesknap committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d11b619 View commit details
    Browse the repository at this point in the history

  3. final changes from Garys review

    @gilesknap
    gilesknap committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e75acab View commit details
    Browse the repository at this point in the history

  4. linting

    @gilesknap
    gilesknap committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d13a171 View commit details
    Browse the repository at this point in the history

  5. fix dependencies test

    @gilesknap
    gilesknap committed May 14, 2024
    Configuration menu
    Copy the full SHA
    10ba7a6 View commit details
    Browse the repository at this point in the history

  6. overhaul globals and test patching

    @gilesknap
    gilesknap committed May 14, 2024
    Configuration menu
    Copy the full SHA
    1aca3ea View commit details
    Browse the repository at this point in the history

  7. some more tests needed epics_root fixture

    @gilesknap
    gilesknap committed May 14, 2024
    Configuration menu
    Copy the full SHA
    49ee13b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. apply Garys PR comments

    @gilesknap
    gilesknap committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2d841f7 View commit details
    Browse the repository at this point in the history

  2. rewrite process_collectiohns as resolve_sub_entities 

    and other review items by Gary on #216
    @gilesknap
    gilesknap committed May 15, 2024
    Configuration menu
    Copy the full SHA
    aba1b13 View commit details
    Browse the repository at this point in the history