Upgrade calc module to EPICS 3.16

[hdante]

No description provided.

[ralphlange]

Careful - Base 3.16 is not even "ready for production" yet.
Is this change compatible with 3.14 and 3.15?

[hdante]

No, this change breaks compatibility with 3.15 and is 3.16 only.

[MarkRivers]

Then we certainly don't want to merge it into the master branch. It would need to go on a 3.16 branch in calc.

[prjemian]

I created a 3.16 branch and a 3.16 milestone in this repository. @hdante, can you close this PR (on master) and open a new PR on the 3.16 branch? Mark your PR with the "EPICS base 3.16" milestone.

[hdante]

Moving to another branch

[anjohnson]

Wrong solution. Instead of using a separate a branch (which would mean you have to make multiple releases, and you have to merge fixes into both branches) you should wrap the change in a conditional that tests the EPICS Base version. Here's how:

#include <epicsVersion.h>
#ifndef EPICS_VERSION_INT
#define VERSION_INT(V,R,M,P) ( ((V)<<24) | ((R)<<16) | ((M)<<8) | (P))
#define EPICS_VERSION_INT VERSION_INT(EPICS_VERSION, EPICS_REVISION, EPICS_MODIFICATION, EPICS_PATCH_LEVEL)
#endif

// ...

#if EPICS_VERSION_INT < VERSION_INT(3,16,0,1)
    pR = (sseqRecord *)(plink->value.pv_link.precord);
#else
    pR = (sseqRecord *)(plink->precord);
#endif

[MarkRivers]

Whoops, you're right I should not have suggested new branch.

[prjemian]

agreed