Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel build dependency rule #8

Merged
merged 1 commit into from Apr 27, 2016
Merged

Fix parallel build dependency rule #8

merged 1 commit into from Apr 27, 2016

Conversation

hdante
Copy link

@hdante hdante commented Apr 27, 2016

No description provided.

@MarkRivers
Copy link
Member

Should't that dependency be in the top-level Makefile in the devIocStats module? That is how it is done in other modules (modbus, std, etc.)

@anjohnson
Copy link
Member

@MarkRivers I may not be understanding your point, but this change looks right to me because both the devIocStats and testIocStats directories are mentioned in this Makefile. The Makefile that sets DIRS += <dir-name> should also set <dir-name>_DEPEND_DIRS to the list of other directories also given in DIRS that must have been built first.

@MarkRivers
Copy link
Member

My mistake, this IS the top-level Makefile. I thought it was lower down.

@stephAllison stephAllison merged commit 6c9da04 into epics-modules:master Apr 27, 2016
@hdante hdante deleted the fix-parallel-build branch October 10, 2016 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants