fix: Correct the setFrequency command #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaget
force-pushed
the
correctFrequencySet
branch
from
2b4fe56
to
4f4046b
Compare
…and period frequency
jerzyjamroz
force-pushed
the
correctFrequencySet
branch
from
4f4046b
to
0bff1a5
Compare
perf: Slightly better accuracy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setFrequency command doesn't set the correct prescaler and so the frequency, because the prescaler is wrongly computed.
We need to use the
m_owner->GetFrequencyand notgetFrequency(), otherwise we obtain a frequency that is not correct and change according to the prescaler computed.It seems you are using git cliff, so I've tried to use a correct commit message, tell me if its ok otherwise I can change it.