Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against overflow/underflow for integer record types #110

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Protect against overflow/underflow for integer record types #110

wants to merge 7 commits into from

Commits on Oct 20, 2022

  1. Raise exception when record type not found

    @AlexanderWells-diamond
    AlexanderWells-diamond committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    8072ce2 View commit details
    Browse the repository at this point in the history

  2. Raise exceptions when value is out of range 

    Long records restricted to int32 min/max, bool to 0 or 1, mbb to 0-15.
    @AlexanderWells-diamond
    AlexanderWells-diamond committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    41ad57f View commit details
    Browse the repository at this point in the history

  3. Use lambda functions to run the valid value test

    @AlexanderWells-diamond
    AlexanderWells-diamond committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    06fe4db View commit details
    Browse the repository at this point in the history

  4. Add value validation to _process 

    This will cause data validation to occur for caput'd values

Also fix tests (previously we were putting invalid values to bool
records)
    @AlexanderWells-diamond
    AlexanderWells-diamond committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    fabae08 View commit details
    Browse the repository at this point in the history

  5. Add tests that .set() rejects invalid values

    @AlexanderWells-diamond
    AlexanderWells-diamond committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c555837 View commit details
    Browse the repository at this point in the history

  6. Add tests for caput using invalid values 

    Note we have to skip mbbOut record testing, as for some reason cothread
caput succeeds for this record type but not for the others
    @AlexanderWells-diamond
    AlexanderWells-diamond committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    5f63e8d View commit details
    Browse the repository at this point in the history

  7. Add changelog message

    @AlexanderWells-diamond
    AlexanderWells-diamond committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    9c19bed View commit details
    Browse the repository at this point in the history