App lost the ability to switch theme in tandem with OS

[andrecasal]

Hey @kentcdodds 👋 On 07a355b removed the ability for the app to adapt to OS theme changes. If the user changes the OS theme, the app doesn't adapt anymore. Was this on purpose?

[onemen]

I see the same on Windows.

changing system theme only apply to the App after F5

more related issues:

• switching theme in the App does not change the value of CH-prefers-color-scheme, is this by design ?, I only see a change in the _session cookie.
• when user log out the App removes the _session cookie and the theme revert back to system theme from CH-prefers-color-scheme value.

[kentcdodds]

You're right, that was a mistake. A fix has been pushed.

switching theme in the App does not change the value of CH-prefers-color-scheme

This is correct. That cookie value is only about what the user's prefers-color-scheme value is. That's the fallback value provided their preference is "system." Their preference is stored in the session.

when user log out the App removes the _session cookie and the theme revert back to system theme from CH-prefers-color-scheme value.

This is a good point. We should probably have a separate cookie for the user's color scheme preference. But it's not the same as CH-prefers-color-scheme. The distinction is important:

1. CH-prefers-color-scheme: The user's system color scheme preference
2. Our new cookie (maybe simply theme?): The user's preference for our app. When "system", we reference the CH-prefers-color-scheme value.

This So yes, this is a bug and should be fixed by adding a separate cookie for managing the theme. No need to sign it either. It can be a raw value.