e2e test expect the page to have changed url but doesn't wait for it to change

[fredericrous]

On my 2019 16" mac, the tests do not run fast enough.
I cannot expect the url to have changed after a test clicks a button.

For example, in onboarding.test.ts this code won't work:

epic-stack/tests/e2e/onboarding.test.ts

Lines 46 to 48 in 9741885

	await createAccountLink.click()
	await expect(page).toHaveURL(`/signup`)

however this code does work:

  await createAccountLink.click()

  await page.waitForURL('/signup');

we can just replace toHaveURL with waitForURL. I mean the test should fail if waitForURL does not resolve, therefore no need to expect on top of waitForURL, right?
Final word, I'm not saying to replace all expect(page).toHaveURL with await page.waitForURL. The ones after await page.goto are fine

also the timeouts are too short. I need to set globaly at least timeout: 20 * 1000. and for the onboarding test reset password with a short code I need to set it to test.setTimeout(30 * 1000);

[kentcdodds]

Interesting. I believe the assertion will wait just as long as the wait utility does. So maybe increasing the timeout is the right solution for you.

[fredericrous]

good catch @kentcdodds indeed the timeout for expect is different. I only modified the timeout for tests.

This also made me realise my tests are taking longer due to how I configured i18next instantiation. I'll be closing the issue and will add my findings to rperon/epic-stack-with-i18n#8

thank you for the quick answer