New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
case count UI #160
case count UI #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I think we can merge so it doesn't desynchronize with master.
Those reformatting stuff are making it harder to review.
Wait - I actually don't see any code which would do what you printscreened at the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the code which should do the change. Was it commited?
Is it necessary to include lines.js
if there are no changes? Isn't that an autoformatting and then git commit -a
combination consequence?
@hnykda I ran this locally and this implement those changes, see these lines: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Styling request:
- Have the "Confirmed cases" and the actual numbers be in separate columns, both of which are left aligned
- Have the actual numbers be in that shade of orange
- Switch around numbers and titles
- Put the "90% confidence interval, based on a combination of statistical modelling and human forecasting" in smaller font below
- Add a separating line before containment measures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, my bad...
OK from my POV, but there are Jacob's additions.
Hey Mati. Thanks a lot, it's still helpful as we are using it in #104, but just not in a sidebar as Jan wanted to remove that one for now. So I am closing this one and @wolverdude is going to do something similar but in the current view |
issue: #144